Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github Actions/Workflows] - update actions/upload-artifact to v4 due to v3 deprecation #51013

Merged

Conversation

pnilan
Copy link
Contributor

@pnilan pnilan commented Jan 9, 2025

What

How

  • actions/upload-artifact@v3 -> actions/upload-artifact@v4
  • The breaking changes from upgrading from v3 to v4 do not impact our use of the library and therefore a 1:1 swap w/o any other changes is possible.

User Impact

  • Faster artifact uploading!
  • Working airbyte-ci-release workflow!

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@pnilan pnilan requested a review from a team as a code owner January 9, 2025 17:40
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 5:40pm

Copy link
Contributor

@ChristoGrab ChristoGrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :shipit:

@pnilan pnilan merged commit 9177c79 into master Jan 9, 2025
25 checks passed
@pnilan pnilan deleted the pnilan/workflows/migrate-to-actions-upload-artifact-v4 branch January 9, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants